Open
Conversation
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug 1:
Problem:
find_module_by_hashused a conditional SEH block aroundExAcquireResourceSharedLiteatPASSIVE_LEVEL.Even though in my test case it executes at PASSIVE_LEVEL, the function occasionally triggered a
FAST_ERESOURCE_PRECONDITION_VIOLATIONorATTEMPT_TO_WRITE_READONLY_MEMORYCause:
the function which has __try/__except block could have catched an internal exception and left the resource not acquired, later the resource was acceded regardless (resource_acquired boolean was defined and set but never was checked).
Solution:
Tested versions:
Bug 2:
on integrity.h:
Problem
IMAGE_SCN_MEM_EXECUTE is a macro defined in ntimage.h, attempting to define a constant/variable with the same name will make expression look like this after preprocessing
which causes a compile time error.
Cause
Including ntimage.h in the working project
Solution
Wrapped the constant definition in a preprocessor guard